feat: implement MacOS 26 Tahoe liquid glass improvements#250
Conversation
|
Requires #248 |
|
This should be possible now. |
|
Needs a rebase |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39914edc8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # The upstream repo has a purposefully limited API | ||
| url: https://github.com/coder/fluid-menu-bar-extra | ||
| revision: b0d5438 | ||
| revision: 0138cb3 |
There was a problem hiding this comment.
In the CI/release environments I inspected, .github/workflows/ci.yml and .github/workflows/release.yml still switch to Xcode 16.4.0; pinning FluidMenuBarExtra to 0138cb3 brings in NSGlassEffectView, which is a macOS 26 SDK symbol. On those current runners the Swift compiler cannot resolve that type before the #available(macOS 26.0, *) runtime check can help, so make test/release builds will fail as soon as SwiftPM resolves this revision. Please update the runner SDK/Xcode in the same change or keep the package revision compatible with Xcode 16.4.
Useful? React with 👍 / 👎.
3 participants
Note
This pull-request is dependent on
coder/fluid-menu-bar-extra#4, keeping in draft until this upstream dependency is merged. And #248 waiting for the Xcode runners to be updated.This pull-request takes our
coder/fluid-menu-bar-extra#4pull-request and applies it to ourcoder/coder-desktop-macoscodebase so that we can take advantage of the new MacOS 26+ Liquid Glass design.Screenshots are lacking as the change is very subtle unless looking on distinct backgrounds.